Skip to content

feat: add chart for wallet and tx count #6134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2025
Merged

feat: add chart for wallet and tx count #6134

merged 1 commit into from
Jan 31, 2025

Conversation

@vernonjohnson
Copy link

@vernonjohnson vernonjohnson commented Jan 31, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on refactoring the TimelineOverview component in TimelineOverview.tsx, enhancing the transaction aggregation logic and improving the rendering of transaction data for a wallet dashboard.

Detailed summary

  • Removed commented-out TimelineOverview component from WalletDashboard.tsx.
  • Introduced a new function getDayKey to format date strings.
  • Refactored transaction aggregation logic to use reduce for daily transaction counts.
  • Simplified data mapping for rendering in the chart.
  • Updated chart configuration to include unique wallets alongside total transactions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vernonjohnson vernonjohnson requested review from a team as code owners January 31, 2025 19:23
@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2025

⚠️ No Changeset found

Latest commit: 309776b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
login 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 7:23pm
thirdweb-www 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 7:23pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jan 31, 2025 7:23pm
thirdweb_playground ⬜️ Skipped (Inspect) Jan 31, 2025 7:23pm
wallet-ui ⬜️ Skipped (Inspect) Jan 31, 2025 7:23pm

@vernonjohnson vernonjohnson merged commit 4d9d611 into hackweek-wallet-explainer Jan 31, 2025
10 of 12 checks passed
@vernonjohnson vernonjohnson deleted the vt-add-timeline-chart-hackweek branch January 31, 2025 19:23
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jan 31, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.6 KB (0%) 933 ms (0%) 2.6 s (-41.63% 🔽) 3.5 s
thirdweb (cjs) 122.39 KB (0%) 2.5 s (0%) 7.9 s (+20.13% 🔺) 10.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 751 ms (+286.5% 🔺) 863 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 182 ms (+37.54% 🔺) 192 ms
thirdweb/react (minimal + tree-shaking) 19.28 KB (0%) 386 ms (0%) 570 ms (-24.45% 🔽) 955 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vernonjohnson